Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federation Experience Frontend - View #525

Merged
merged 13 commits into from
Nov 1, 2024
Merged

Federation Experience Frontend - View #525

merged 13 commits into from
Nov 1, 2024

Conversation

sestuna117
Copy link

Signed-off-by: Jason-Guo [email protected]

Jason-Guo added 9 commits October 8, 2024 11:35
add federation navbar links
2e81bf5 
Signed-off-by: Jason-Guo <[email protected]>
create copy of cluster list for federations
a21c2bd 
Signed-off-by: Jason-Guo <[email protected]>
add route to federations list
9a3ebfb 
Signed-off-by: Jason-Guo <[email protected]>
update names for classes and functions
aa3f54b 
Signed-off-by: Jason-Guo <[email protected]>
add api call on render and removed unavailable manager version call
5b1267f 
Signed-off-by: Jason-Guo <[email protected]>
fix update list func for federations
1b9ef96 
Signed-off-by: Jason-Guo <[email protected]>
update route url
435341f 
Signed-off-by: Jason-Guo <[email protected]>
Create table and types for federations
fb6d13c 
Signed-off-by: Jason-Guo <[email protected]>
correctly display data on table
e84a927 
Signed-off-by: Jason-Guo <[email protected]>
@sestuna117 sestuna117 marked this pull request as ready for review October 21, 2024 15:13
mamy-CS
mamy-CS reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's add an Info column, same as "Agents list" table where we dump the federation relationship info in a json format. See here for an example:

tornjak/frontend/src/tables/agents-list-table.tsx

Line 77 in 71a03a4

listtabledata[i]["info"] = JSON.stringify(listData[i].props.agent, null, ' ');

Screenshot 2024-10-21 at 1 11 15 PM

frontend/src/components/navbar.tsx Outdated Show resolved Hide resolved
frontend/src/components/federation-list.tsx Outdated Show resolved Hide resolved
frontend/src/tables/federations-list-table.tsx Outdated Show resolved Hide resolved
Jason-Guo added 2 commits October 21, 2024 13:20
@mamy-CS
Copy link
Collaborator

mamy-CS commented Oct 21, 2024

Add move the Federations nav after Entries navlink on the navbar.

Jason-Guo added 2 commits October 22, 2024 09:08
@sestuna117
Copy link
Author

Suggested changes have been made and pushed

  • removed unused imports
  • moved location on navbar
  • included Info column in table

@sestuna117 sestuna117 requested a review from mamy-CS October 22, 2024 13:12
mamy-CS
mamy-CS approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thank you for your contribution @sestuna117

@mamy-CS mamy-CS merged commit 1bbbc34 into spiffe:main Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamy-CS mamy-CS mamy-CS approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

@maia-iyer maia-iyer Awaiting requested review from maia-iyer maia-iyer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sestuna117 @mamy-CS