Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET ClusterFederatedTrustDomain API #542

Merged
merged 26 commits into from
Oct 28, 2024
Merged

Add GET ClusterFederatedTrustDomain API #542

merged 26 commits into from
Oct 28, 2024

Conversation

maia-iyer
Copy link
Collaborator

@maia-iyer maia-iyer commented Oct 21, 2024

Partially addresses #543 by implementing the GET API.

Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
@maia-iyer maia-iyer added backend Tornjak API (Backend) go Pull requests that update Go code labels Oct 21, 2024
@maia-iyer maia-iyer added this to the 2.0.0 milestone Oct 21, 2024
@maia-iyer maia-iyer self-assigned this Oct 21, 2024
@maia-iyer maia-iyer marked this pull request as ready for review October 22, 2024 19:08
Signed-off-by: Maia Iyer <[email protected]>
Signed-off-by: Maia Iyer <[email protected]>
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice extension to our Tornjak APIs. Thank you for adding this useful function! LGTM

@maia-iyer maia-iyer merged commit a9b1767 into main Oct 28, 2024
10 checks passed
@maia-iyer maia-iyer deleted the get_federation_crd branch October 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants