Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Index Page for Docs #556

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Created Index Page for Docs #556

merged 5 commits into from
Dec 2, 2024

Conversation

mattLif
Copy link
Contributor

@mattLif mattLif commented Nov 19, 2024

Sorts and links to documentation pages in alphabetical order, and lists and links to their specific headers.

@maia-iyer
Copy link
Collaborator

Looks like the linting failed for the new file. To fix this

  1. cd frontend
  2. npm run lint:fix
  3. add/commit/push changes

Signed-off-by: Matthew <[email protected]>
@mattLif
Copy link
Contributor Author

mattLif commented Nov 21, 2024

Should be all good now.

Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Let me know if you have any questions about these comments

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@maia-iyer maia-iyer linked an issue Nov 22, 2024 that may be closed by this pull request
@mattLif
Copy link
Contributor Author

mattLif commented Nov 22, 2024

Alright, I just committed all changes you requested. Anything else you might want done?

Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing is let's rename the docs/index.md to docs/README.md so that the preview shows in the Github UI

@maia-iyer maia-iyer merged commit e2278dd into spiffe:main Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Index with Links
3 participants