Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uid key (not finished but this is the changes I have made so far) #561

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ArnavPawar
Copy link

I need to keep working on this. I didnt realieze how much I would need to change when I started this and have tested things but it need to be fixed. Some things may not be needed and some may need to be expanded on.

This was the feature to add a unique id to each cluster that gets created(cluster api)

@ArnavPawar ArnavPawar marked this pull request as draft December 9, 2024 21:42
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might make a couple preliminary suggestions:

  1. the DCO is not passing - but because you are the only author, if you view the details of the failed test, it will tell you how to fix
  2. I might suggest you create a new cluster API for now to test things. For example, in api/agent/server.go you can add a new line around lines 220-230 for clustercreate like the following:
apiRtr.HandleFunc("/api/v1/tornjak/clustersbeta", s.ClusterCreateByUID).Methods(http.MethodPost)

Then test using this new API - might be easier to deal with so you do not have to worry about implementing in the frontend or manager. In general, when APIs are updated, we like to maintain the current implementation until the new feature is ready, then give notice of deprecation.

If you do this, then I believe you shouldn't have to touch anything but some files in api/agent and pkg/agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants