feat(servergroup): Allow users to opt-out of the target desired size check when verifying if the instances scaled up or down successfully

[ovidiupopa07]

Some of our users prefer to use the actual instance size list to verify if everything was scaled up or down accordingly instead of relying on the target percentage. They noticed this is causing instability on their end

[jasonmcintosh]

Kinda want to figure out a better properties organization strategy, e.g. a config.sg.use-resize-server-group option. I'd personally prefer to have "resize-server-group" to also match the variable "config.sg.use-target-desired-size" option.

Other question: IS there a need to allow this PER operation. E.g. "context.get("useTargetGroupDesiredSize") to figure out which path to use?

[ovidiupopa07]

IS there a need to allow this PER operation. E.g. "context.get("useTargetGroupDesiredSize") to figure out which path to use?

I don't think there's a need to extract this to stage/operation level. This is just for the match capacity task to use real number of instances instead of relying on the percentage stuff

[ovidiupopa07]

Kinda want to figure out a better properties organization strategy, e.g. a config.sg.use-resize-server-group option. I'd personally prefer to have "resize-server-group" to also match the variable "config.sg.use-target-desired-size" option.

Makes sense. What about server-group.resize.match-instances-size? I would keep the match-instances-size to ensure we are intentional about the behavior that can be enabled for the resize. (e.g. use the instances size to match which was the default behavior before #3785 was merged, instead of the target desired size )

[ovidiupopa07]

@Mergifyio backport release-1.28.x

[mergify]

backport release-1.28.x

✅ Backports have been created

• #4650 feat(servergroup): Allow users to opt-out of the target desired size check when verifying if the instances scaled up or down successfully (backport #4649) has been created for branch release-1.28.x

[ovidiupopa07]

@Mergifyio backport release-1.33.x release-1.32.x release-1.31.x

[mergify]

backport release-1.33.x release 1.32.x release-1.31.x

❌ No backport have been created

• #4651 feat(servergroup): Allow users to opt-out of the target desired size check when verifying if the instances scaled up or down successfully (backport #4649) has been created for branch release-1.33.x
• Backport to branch release failed

GitHub error: Branch not found

• Backport to branch 1.32.x failed

GitHub error: Branch not found

• #4652 feat(servergroup): Allow users to opt-out of the target desired size check when verifying if the instances scaled up or down successfully (backport #4649) has been created for branch release-1.31.x

[mergify]

backport release-1.33.x release-1.32.x release-1.31.x

✅ Backports have been created

• #4651 feat(servergroup): Allow users to opt-out of the target desired size check when verifying if the instances scaled up or down successfully (backport #4649) has been created for branch release-1.33.x
• #4653 feat(servergroup): Allow users to opt-out of the target desired size check when verifying if the instances scaled up or down successfully (backport #4649) has been created for branch release-1.32.x
• #4652 feat(servergroup): Allow users to opt-out of the target desired size check when verifying if the instances scaled up or down successfully (backport #4649) has been created for branch release-1.31.x