Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer.json now compatible with Composer v2 #23

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Composer.json now compatible with Composer v2 #23

merged 1 commit into from
Jan 24, 2022

Conversation

polevaultweb
Copy link
Contributor

Resolves #22

rosswintle
rosswintle reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@rosswintle rosswintle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on Composer v2.2. and this additionally wanted "dealerdirect/phpcodesniffer-composer-installer": true when I did composer install.

Did you not see this or did you deny it for a reason?

@polevaultweb
Copy link
Contributor Author

Are you still on the #19 branch?

@rosswintle
Copy link
Contributor

Oh. composer.lock isn't in Git. So yes, in my case, this includes stuff from that branch.

Monday morning...

Yes, merge this and I'll then merge master into #19 and re-update.

@polevaultweb polevaultweb merged commit 3d4e7c4 into master Jan 24, 2022
@polevaultweb polevaultweb deleted the 22-composer-v2 branch January 24, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosswintle rosswintle rosswintle approved these changes

Assignees
No one assigned
Labels
ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composer v2 compatibility
2 participants
@polevaultweb @rosswintle