Merge pull request #49 from spira/feature/elasticsearch-exception

Fix ElasticSearchIndexer exception
spira · Apr 19, 2016 · c37fe48 · c37fe48
2 parents 1d31ab7 + 13a93e0
commit c37fe48
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Model/Model/ElasticSearchIndexer.php b/Model/Model/ElasticSearchIndexer.php
@@ -107,7 +107,7 @@ protected function getRelationsForReindex(IndexedModel $model)
     protected function getRelationItems(IndexedModel $model, $relation)
     {
         if (! method_exists($model, $relation)) {
-            throw new \Exception(sprintf('Tried to reindex unexistant relation "%s" on model "%s"', $relation, $model->getMorphClass()));
+            throw new \BadMethodCallException(sprintf('Tried to reindex non-existent relation "%s" on model "%s"', $relation, $model->getMorphClass()));
         }
 
         /** @var Relation $rel */

diff --git a/tests/ElasticSearchIndexerTest.php b/tests/ElasticSearchIndexerTest.php
@@ -16,8 +16,8 @@
 class ElasticSearchIndexerTest extends TestCase
 {
     /**
-     * @expectedException \Exception
-     * @expectedExceptionMessage Tried to reindex unexistant relation "badRelation" on model "Spira\Core\Model\Model\IndexedModel"
+     * @expectedException \BadMethodCallException
+     * @expectedExceptionMessage Tried to reindex non-existent relation "badRelation" on model "Spira\Core\Model\Model\IndexedModel"
      */
     public function testUnexistantRelationError()
     {