more

spiraldb · Jan 23, 2025 · 2330277 · 2330277
1 parent 33ee69a
commit 2330277
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/encodings/dict/src/compute/compare.rs b/encodings/dict/src/compute/compare.rs
@@ -42,7 +42,7 @@ impl CompareFn<DictArray> for DictEncoding {
         if selection.selectivity() < 0.2 {
             if let Some(const_scalar) = rhs.as_constant() {
                 // Ensure the other is the same length as the dictionary
-                println!("lhs.values().len() = {}", lhs.values().len());
+                // println!("lhs.values().len() = {}", lhs.values().len());
                 let compare_result = compare(
                     lhs.values(),
                     ConstantArray::new(const_scalar, lhs.values().len()),

diff --git a/vortex-array/src/canonical.rs b/vortex-array/src/canonical.rs
@@ -416,7 +416,7 @@ pub trait IntoCanonical {
         Self: Sized,
         Self: AsRef<ArrayData>,
     {
-        if mask.selectivity() < 0.2 {
+        if mask.selectivity() < 0.99 {
             filter(self.as_ref(), mask)?.into_canonical()
         } else {
             filter(self.into_canonical()?.as_ref(), mask)?.into_canonical()

diff --git a/vortex-array/src/data/mod.rs b/vortex-array/src/data/mod.rs
@@ -270,12 +270,12 @@ impl ArrayData {
     }
 
     pub fn metadata_bytes(&self) -> Option<&[u8]> {
-        println!("encoding {:?}", self.encoding().id());
+        //println!("encoding {:?}", self.encoding().id());
         let md = match &self.0 {
             InnerArrayData::Owned(d) => d.metadata.as_ref().map(|b| b.as_slice()),
             InnerArrayData::Viewed(v) => v.flatbuffer().metadata().map(|m| m.bytes()),
         };
-        println!("md bytes {:?}", md);
+        //println!("md bytes {:?}", md);
         md
     }
 

diff --git a/vortex-layout/src/layouts/flat/eval_expr.rs b/vortex-layout/src/layouts/flat/eval_expr.rs
@@ -55,7 +55,7 @@ impl ExprEvaluator for FlatReader {
         );
 
         // Decode into an ArrayData.
-        println!("decoding array of type {}", self.dtype());
+        // println!("decoding array of type {}", self.dtype());
         let array = array_parts.decode(self.ctx(), self.dtype().clone())?;
         assert_eq!(
             array.len() as u64,