Return empty conjunct list if filter is true (#2027)

spiraldb · Jan 20, 2025 · b4e4f5a · b4e4f5a
1 parent 452b02b
commit b4e4f5a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/vortex-expr/src/forms/cnf.rs b/vortex-expr/src/forms/cnf.rs
@@ -2,7 +2,7 @@ use vortex_error::VortexResult;
 
 use super::nnf::nnf;
 use crate::traversal::{Node as _, NodeVisitor, TraversalOrder};
-use crate::{BinaryExpr, ExprRef, Operator};
+use crate::{lit, BinaryExpr, ExprRef, Operator};
 
 /// Return an equivalent expression in Conjunctive Normal Form (CNF).
 ///
@@ -143,6 +143,10 @@ use crate::{BinaryExpr, ExprRef, Operator};
 /// ```
 ///
 pub fn cnf(expr: ExprRef) -> VortexResult<Vec<Vec<ExprRef>>> {
+    if expr == lit(true) {
+        // True in CNF
+        return Ok(vec![]);
+    }
     let nnf = nnf(expr)?;
 
     let mut visitor = CNFVisitor::default();