Fixed another bug with erase

src/classes/list/doubly_linked_list.h

@@ -174,14 +174,14 @@ template <typename T> bool doubly_linked_list<T>::search(T key) {
 
 template <typename T> void doubly_linked_list<T>::push_back(T key) {
   std::shared_ptr<node> p = std::make_shared<node>(key);
-  if (root == nullptr) {
-    root = p;
-  }
+  p->prev = tail;
+  p->next = nullptr;
   if (tail != nullptr) {
     tail->next = p;
   }
-  p->next = nullptr;
-  p->prev = tail;
+  if (root == nullptr) {
+    root = p;
+  }
   tail = p;
   _size++;
 }
@@ -215,9 +215,15 @@ template <typename T> void doubly_linked_list<T>::erase(T key) {
     return;
   }
   if (head->next != nullptr) {
+    if(head == root) {
+        root = root -> next;
+    }
     head->next->prev = head->prev;
   }
   if (head->prev != nullptr) {
+    if(head == tail) {
+        tail = tail->prev;
+    }
     head->prev->next = head->next;
   }
 }

tests/list/doubly_list.cc

@@ -153,7 +153,6 @@ TEST_CASE("Testing searching for issue #88") {
     for(auto it = l2.begin(); it != l2.end(); it++) {
         REQUIRE(*(it) == check[idx++]);
     }
-    std::cout << "im here as well" << '\n';
 
     // Bug in erase method
     doubly_linked_list<int> l3({1, 2, 3});
@@ -166,6 +165,15 @@ TEST_CASE("Testing searching for issue #88") {
     for(auto it = l3.begin(); it != l3.end(); it++) {
         REQUIRE(*(it) == check[idx++]);
     }
+
+    doubly_linked_list<int> l4({1, 2, 3});
+    l4.erase(3);
+    REQUIRE(l4.search(3) == false);
+    l4.push_back(3);
+    for(auto it = l4.begin(); it != l4.end(); it++) {
+        std::cout << *(it) << ' ';
+    }
+    REQUIRE(l4.search(3) == true);
 }