Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed+ #98

Merged
merged 6 commits into from
Dec 26, 2024
Merged

Fixed+ #98

merged 6 commits into from
Dec 26, 2024

Conversation

sheldonrobinson
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot reviewed Dec 26, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your interest in AlgoPlus, a maintainer will see your PR soon!

@sheldonrobinson
Copy link
Contributor Author

Fix #97

spirosmaggioros
spirosmaggioros reviewed Dec 26, 2024
View reviewed changes
src/algorithms/rmq/rmq_sparse_table.h
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, i never thought of this.

spirosmaggioros
spirosmaggioros reviewed Dec 26, 2024
View reviewed changes
Copy link
Owner

@spirosmaggioros spirosmaggioros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thank's for the issue and the PR.
Will look at the bit counter and the different func names tomorrow morning(ATH time) and will merge it if everything looks good.

@spirosmaggioros spirosmaggioros linked an issue Dec 26, 2024 that may be closed by this pull request
Errors compiling 'src/.../skip_list.h','tests/.../minimum_swaps.cc', 'tests/.../image.cc' and 'src/.../rmq_sparse_table.h' #97
Closed
@spirosmaggioros spirosmaggioros added bug Something isn't working unit_tests labels Dec 26, 2024
@spirosmaggioros spirosmaggioros merged commit c73045b into spirosmaggioros:main Dec 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spirosmaggioros spirosmaggioros spirosmaggioros left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@sheldonrobinson sheldonrobinson

@spirosmaggioros spirosmaggioros

Labels
bug Something isn't working unit_tests
Projects
None yet
Milestone
No milestone
2 participants
@sheldonrobinson @spirosmaggioros