Workspaces Part I #1160
Merged
Workspaces Part I #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrray
requested changes
Jan 13, 2025
Signed-off-by: Ryan Bottriell <[email protected]>
Signed-off-by: Ryan Bottriell <[email protected]>
Signed-off-by: Ryan Bottriell <[email protected]>
Signed-off-by: Ryan Bottriell <[email protected]>
Signed-off-by: Ryan Bottriell <[email protected]>
Signed-off-by: Ryan Bottriell <[email protected]>
Signed-off-by: Ryan Bottriell <[email protected]>
Signed-off-by: Ryan Bottriell <[email protected]>
Although the concept is largely hidden (aside from the new flags) this adds the ability to define a workspace in the current directory and modify the default behavior of only loading spk.yaml files from the current directory. Signed-off-by: Ryan Bottriell <[email protected]>
Signed-off-by: Ryan Bottriell <[email protected]>
jrray
reviewed
Jan 14, 2025
Co-authored-by: jrray <[email protected]> Signed-off-by: Ryan Bottriell <[email protected]>
jrray
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be the first of a few related to #1121
This first PR introduces the
spk-workspacecrate that defines the structure of aworkspace.spk.yamlfile and updates the various spk commands to recognize it. By default, a "virtual" workspace is created which collects all*.spk.yamlfiles in the current directory (this is in-line with previous behavior). The only new feature that becomes unlocked by this is that you can create aworkspace.spk.yamlthat collects files from additional or different paths.For example, this repository now has a workspace file that makes
spk build spk-convert-pipwork from anywhere within it, finding and building from the spec file under the packages folder.