Refactor: add init method and onReadyFromCacheCb param to storage factory [WIP]
#352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
changed the base branch from
SDKS-8407_baseline
to
init_function_for_side_effects
EmilianoSanchez
changed the title
onReadyFromCacheCb to storage factory params for code cleanupinit method and onReadyFromCacheCb param to storage factory [WIP]
Base automatically changed from
init_function_for_side_effects
to
SDKS-8407_baseline
October 18, 2024 15:04
EmilianoSanchez
added a commit
to splitio/javascript-client
that referenced
this pull request
Oct 18, 2024
EmilianoSanchez
changed the base branch from
SDKS-8407_baseline
to
breaking_changes_baseline
Base automatically changed from
breaking_changes_baseline
to
SDKS-8407_baseline
November 1, 2024 20:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript commons library
What did you accomplish?
initstorage method to support lazy initialization of Pluggable and Redis storages.onReadyFromCacheCbto storage factory params to handle the emittion of the SDK_SPLITS_CACHE_LOADED (and SDK_READY_FROM_CACHE) event in a single place, making possible to remove some redundant code.How do we test the changes introduced in this PR?
Extra Notes
InRedisStorage::init