Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix on server-side polling manager #355

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Bugfix on server-side polling manager #355

merged 1 commit into from
Oct 4, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

JavaScript commons library

What did you accomplish?

  • Bugfixing - Fixed an issue with the server-side polling manager that caused dangling timers when the SDK was destroyed before it was ready.

How do we test the changes introduced in this PR?

  • E2E tests in JS SDK.

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner October 4, 2024 18:04
@EmilianoSanchez EmilianoSanchez merged commit cefdec9 into development Oct 4, 2024
2 checks passed
@EmilianoSanchez EmilianoSanchez deleted the bugfix_server_side_polling_manager branch October 4, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthea gthea gthea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @gthea