[Breaking change] Fix client ready() method when using async/await syntax [ON HOLD]
#358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_changes_ready_method
…ing_changes_ready_method
EmilianoSanchez
changed the base branch from
breaking_changes
to
breaking_changes_remove_deprecated_features
EmilianoSanchez
changed the title
ready() method when using async/await syntaxready() method when using async/await syntax [ON HOLD]
Base automatically changed from
breaking_changes_remove_deprecated_features
to
breaking_changes_update_supported_runtimes
October 18, 2024 16:32
Base automatically changed from
breaking_changes_update_supported_runtimes
to
breaking_changes
October 18, 2024 16:32
Base automatically changed from
breaking_changes
to
breaking_changes_baseline
October 18, 2024 16:36
Base automatically changed from
breaking_changes_baseline
to
SDKS-8407_baseline
November 1, 2024 20:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript commons library
What did you accomplish?
readymethod that caused the returned promise to hang on async/await syntax if it was rejected.How do we test the changes introduced in this PR?
Extra Notes