Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): relocate button from dropdown to action column In input page #1148

Merged
merged 23 commits into from
May 8, 2024
Merged

feat(search): relocate button from dropdown to action column In input page #1148

merged 23 commits into from
May 8, 2024

Conversation

rohanm-crest
Copy link
Contributor

  • Remove the button "Show name input events" from dropdown in input page.
  • Add a search button in action column which opens a new tab.

@vtsvetkov-splunk
Copy link
Contributor

please rename PR title according to conventional commits rule

@rohanm-crest rohanm-crest self-assigned this Apr 19, 2024
@rohanm-crest rohanm-crest changed the title "Fix: Relocate button from dropdown to action column In input page" fix(code): relocate button from dropdown to action column In input page Apr 22, 2024
@rohanm-crest rohanm-crest changed the title fix(code): relocate button from dropdown to action column In input page feat(code): relocate button from dropdown to action column In input page Apr 23, 2024
@rohanm-crest rohanm-crest marked this pull request as ready for review April 23, 2024 12:18
@rohanm-crest rohanm-crest requested review from a team as code owners April 23, 2024 12:18
@rohanm-crest rohanm-crest changed the title feat(code): relocate button from dropdown to action column In input page feat(search): relocate button from dropdown to action column In input page Apr 23, 2024
@rohanm-crest rohanm-crest mentioned this pull request Apr 24, 2024
Merged
vtsvetkov-splunk
vtsvetkov-splunk requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add it in storybook for visual regression testing

ui/src/components/table/CustomTableRow.jsx Outdated Show resolved Hide resolved
ui/src/components/table/CustomTableRow.jsx Outdated Show resolved Hide resolved
@rohanm-crest rohanm-crest force-pushed the ADDON-68581-add-search branch from 7c720e1 to 0377c4d Compare April 25, 2024 11:34
vtsvetkov-splunk
vtsvetkov-splunk previously requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to fix lint issues

ui/src/components/table/CustomTableRow.jsx Outdated Show resolved Hide resolved
ui/src/components/table/CustomTableStyle.jsx Outdated Show resolved Hide resolved
ui/src/components/table/CustomTableStyle.jsx Outdated Show resolved Hide resolved
ui/src/components/table/CustomTableStyle.jsx Outdated Show resolved Hide resolved
@artemrys artemrys requested a review from soleksy-splunk May 6, 2024 10:09
soleksy-splunk
soleksy-splunk previously approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

artemrys
artemrys previously approved these changes May 7, 2024
View reviewed changes
@soleksy-splunk
Copy link
Contributor

soleksy-splunk commented May 7, 2024 •
edited
Loading

@rohanm-crest can you resolve that one conflict? After that lets merge it.

@rohanm-crest rohanm-crest dismissed stale reviews from artemrys and soleksy-splunk via 7340150 May 7, 2024 11:59
@rohanm-crest rohanm-crest requested a review from artemrys May 7, 2024 12:02
@soleksy-splunk soleksy-splunk enabled auto-merge (squash) May 7, 2024 18:31
@rohanm-crest
Copy link
Contributor Author

don't forget to fix lint issues

Resolved

auto-merge was automatically disabled May 8, 2024 05:08

Pull request was closed

@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
@rohanm-crest rohanm-crest reopened this May 8, 2024
@artemrys artemrys dismissed vtsvetkov-splunk’s stale review May 8, 2024 08:17

Requested changes were implemented and requestor is OOO this week.

@artemrys artemrys merged commit 696e5a9 into develop May 8, 2024
108 checks passed
@artemrys artemrys deleted the ADDON-68581-add-search branch May 8, 2024 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hetangmodi-crest hetangmodi-crest hetangmodi-crest approved these changes

@soleksy-splunk soleksy-splunk soleksy-splunk approved these changes

@vtsvetkov-splunk vtsvetkov-splunk Awaiting requested review from vtsvetkov-splunk

@artemrys artemrys Awaiting requested review from artemrys

Assignees

@rohanm-crest rohanm-crest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rohanm-crest @vtsvetkov-splunk @soleksy-splunk @artemrys @hetangmodi-crest @srv-rr-github-token