Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs): show input services status count #1430

Merged
merged 22 commits into from
Nov 20, 2024

Conversation

rohanm-crest
Copy link
Contributor

@rohanm-crest rohanm-crest commented Nov 5, 2024

Issue number: ADDON-76033

Summary

Changes

Added input services status count in the table header

User experience

User can see the status (enables/disabled) count in the table header of inputs page.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@vtsvetkov-splunk vtsvetkov-splunk added the javascript Pull requests that update Javascript code label Nov 5, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 6, 2024
ui/src/components/table/TableHeader.jsx Outdated Show resolved Hide resolved
ui/src/components/table/TableHeader.jsx Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see if this new functionality is auto-tested somehow. Can you add at least show it off in screenshot testing by adding more inputs there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, is to cover with unit tests (TableWrapper.test.tsx)

@rohanm-crest rohanm-crest requested a review from a team as a code owner November 15, 2024 06:44
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 15, 2024
Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vtsvetkov-splunk vtsvetkov-splunk merged commit 2574451 into develop Nov 20, 2024
98 checks passed
@vtsvetkov-splunk vtsvetkov-splunk deleted the feat/show-status-count branch November 20, 2024 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript Pull requests that update Javascript code size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants