-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display newest information in row more info section #1445
Conversation
do you think it is feasible to add the test to reproduce the bug, then fix it and fix the test? |
yeah sure, will add the test case first that will cover the bug and fix them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets add some tests to it
since you already checked most of the file maybe worth moving to typescript or even convert to functional component for consistency (most of components are made that way), wdyt? or maybe better to do it in separate PR |
…unk/addonfactory-ucc-generator into bugfix/load-data-in-moreinfo
…unk/addonfactory-ucc-generator into bugfix/load-data-in-moreinfo
Yeah, sure, we will take the functional + typescript part conversion in separate ticket. |
Issue number: ADDON-76309
Closes #1410.
Summary
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.