Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display newest information in row more info section #1445

Merged
merged 15 commits into from
Nov 25, 2024

Conversation

rohanm-crest
Copy link
Contributor

@rohanm-crest rohanm-crest commented Nov 11, 2024

Issue number: ADDON-76309

Closes #1410.

Summary

Changes

More info data is getting updated when the row is expanded

User experience

User can update the row details and check the updated data will render when the row is expanded.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@rohanm-crest rohanm-crest requested a review from a team as a code owner November 11, 2024 13:12
@rohanm-crest rohanm-crest self-assigned this Nov 11, 2024
@vtsvetkov-splunk vtsvetkov-splunk added the javascript Pull requests that update Javascript code label Nov 12, 2024
@vtsvetkov-splunk
Copy link
Contributor

do you think it is feasible to add the test to reproduce the bug, then fix it and fix the test?

@pull-request-size pull-request-size bot added size/L and removed size/S labels Nov 12, 2024
@rohanm-crest
Copy link
Contributor Author

rohanm-crest commented Nov 12, 2024

do you think it is feasible to add the test to reproduce the bug, then fix it and fix the test?

yeah sure, will add the test case first that will cover the bug and fix them

Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add some tests to it

@soleksy-splunk
Copy link
Contributor

since you already checked most of the file maybe worth moving to typescript or even convert to functional component for consistency (most of components are made that way), wdyt?

or maybe better to do it in separate PR

@rohanm-crest rohanm-crest enabled auto-merge (squash) November 21, 2024 12:03
@rohanm-crest
Copy link
Contributor Author

since you already checked most of the file maybe worth moving to typescript or even convert to functional component for consistency (most of components are made that way), wdyt?

or maybe better to do it in separate PR

Yeah, sure, we will take the functional + typescript part conversion in separate ticket.

@rohanm-crest rohanm-crest merged commit 2b34c6b into develop Nov 25, 2024
98 checks passed
@rohanm-crest rohanm-crest deleted the bugfix/load-data-in-moreinfo branch November 25, 2024 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript Pull requests that update Javascript code size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Inputs table do not reflect the changes when input is edited
3 participants