-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom REST handlers without UI in web.conf and restmap.conf #1532
base: feat/handlers-custom-logic
Are you sure you want to change the base?
feat: add support for custom REST handlers without UI in web.conf and restmap.conf #1532
Conversation
Suggested pull request title: I appreciate the thorough implementation of support for custom REST handlers in the global configuration. The code is well-structured and includes comprehensive test coverage. The implementation follows good practices by separating concerns into appropriate classes and methods. However, there are a few areas that could be improved:
Overall, the code appears to be ready for merging after addressing these minor issues. The implementation provides a useful feature for defining custom REST handlers without requiring UI components, and it's well-tested with both unit tests and integration tests. This comment was added by our PR Review Assistant Bot. Please kindly acknowledge that To reply to the review and engage Review Bot in further conversation, start your comment with the words |
# Conflicts: # tests/testdata/test_addons/package_global_config_everything/globalConfig.json
Issue number: ADDON-75952
PR Type
What kind of change does this PR introduce?
Summary
Changes
Second PR. It allows to specify REST handlers not generated by UCC in globalConfig. Based on that, UCC will extend openapi.json, web.conf and restmap.conf.
User experience
Nothing changes in existing addons. This feature introduces new options in global config.
Checklist
If an item doesn't apply to your changes, leave it unchecked.