chore(npm): build TS to JS when publishing #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
Signed-off-by: Viktor Tsvetkov <[email protected]>
rohanm-crest
approved these changes
Feb 12, 2025
soleksy-splunk
approved these changes
Feb 13, 2025
| * `yarn run test-storybook:update-snapshots` – Updates screenshots. Run this after any visual modifications. | ||
| * `yarn run eslint` – Executes linters. | ||
| * `yarn run eslint:fix` – Addresses linter issues and applies Prettier formatting. | ||
| * `yarn run format` – Uses Prettier to automatically format source code files. This command overwrites files without prompting. Use `format:verify` for a non-destructive check. |
There was a problem hiding this comment.
should we add yarn run lint here? as combination for eslint and format
Suggested change
| * `yarn run format` – Uses Prettier to automatically format source code files. This command overwrites files without prompting. Use `format:verify` for a non-destructive check. | |
| * `yarn run format` – Uses Prettier to automatically format source code files. This command overwrites files without prompting. Use `format:verify` for a non-destructive check. | |
| * `yarn run lint` – combination of linters and Prettier formating |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-76810
PR Type
What kind of change does this PR introduce?
Summary
We ship not only type, but some classes to extend, so it needs to be bundled and shipped as JS.
Changes
User experience
They can use class extension in their code
Checklist
If an item doesn't apply to your changes, leave it unchecked.