Fix missing sid when there is an error.

splunk · Aug 28, 2023 · 32bb047 · 32bb047
1 parent 79b7fbd
commit 32bb047
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/contentctl/objects/test_config.py b/contentctl/objects/test_config.py
@@ -194,8 +194,6 @@ def validate_full_image_path(cls, v, values):
             try:
                 # connectivity to docker server is validated previously
                 client = docker.from_env()
-                print("SKIPPING PULL FOR SPEED")
-                return v
                 print(
                     f"Getting the latest version of the container image: {v}...",
                     end="",

diff --git a/contentctl/objects/unit_test_result.py b/contentctl/objects/unit_test_result.py
@@ -9,6 +9,7 @@
 
 FORCE_TEST_FAILURE_FOR_MISSING_OBSERVABLE = False
 
+NO_SID = "Testing Failed, NO Search ID"
 SID_TEMPLATE = "{server}:{web_port}/en-US/app/search/search?sid={sid}"
 
 
@@ -88,6 +89,7 @@ def set_job_content(
             self.job_content = None
             self.success = False
             self.message = f"Error during test: {str(content)}"
+            self.sid_link = NO_SID
 
         return self.success