-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more custom indexes #309
Conversation
modify: configure_hec to use get_all_indexes during HEC creation
Allow testing with the default or custom_index
…a custom_index that does not exist on the target server. list out the attempted index and all indexes on the server for documentation purposes.
See the following error, which is now generated and dumped into test_results/summary.yml, when trying to replay data into an index that does not exist on the target server. It should be nice and verbose, listing the index you attempted to replay into and all the indexes that DO exist on the server. @ax-hsmith - could you take a look at this and tell us your thoughts? Do you think this is an improvement that gives even more information? Thanks! |
for contentctl
Hi @pyth0n1c! First, thanks for considering my PR for merge. It's truly a pleasure to contribute to such an amazing project! To answer your question, yes, having the exception/error in the results is a welcomed improvement. I think it also may be worthwhile to update the README or documentation somewhere to indicate "if you wish to use a |
This PR contains changes from the following PR contributed by community member @ax-hsmith.
The additional change we will make here is that the get_all_indexes function will also include the standard contentctl replay index.
We will also consider comment #307 (comment) for additional changes.