Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more custom indexes #309

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Add more custom indexes #309

merged 9 commits into from
Oct 16, 2024

Conversation

pyth0n1c
Copy link
Contributor

This PR contains changes from the following PR contributed by community member @ax-hsmith.

The additional change we will make here is that the get_all_indexes function will also include the standard contentctl replay index.

We will also consider comment #307 (comment) for additional changes.

@pyth0n1c pyth0n1c changed the title All more custom indexes Add more custom indexes Oct 16, 2024
…a custom_index that does not exist on the target server. list out the attempted index and all indexes on the server for documentation purposes.
@pyth0n1c
Copy link
Contributor Author

pyth0n1c commented Oct 16, 2024

See the following error, which is now generated and dumped into test_results/summary.yml, when trying to replay data into an index that does not exist on the target server. It should be nice and verbose, listing the index you attempted to replay into and all the indexes that DO exist on the server.
This is checked at individual test time, not during validate or initial test set up.
image

@ax-hsmith - could you take a look at this and tell us your thoughts? Do you think this is an improvement that gives even more information?

Thanks!

@pyth0n1c pyth0n1c merged commit cfda377 into main Oct 16, 2024
10 of 18 checks passed
@ax-hsmith
Copy link
Contributor

Hi @pyth0n1c!

First, thanks for considering my PR for merge. It's truly a pleasure to contribute to such an amazing project!

To answer your question, yes, having the exception/error in the results is a welcomed improvement.

I think it also may be worthwhile to update the README or documentation somewhere to indicate "if you wish to use a custom_index during tests, you must include a Splunk app in contentctl.yml that has the index pre-defined in it's configuration. For more information refer to https://docs.splunk.com/Documentation/Splunk/9.3.1/Admin/Indexesconf#indexes.conf.example (or something similar). I am happy to help with this if you think it's worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants