Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixing documentation #836

Merged
merged 5 commits into from
May 14, 2024
Merged

Conversation

harshilgajera-crest
Copy link
Contributor

@harshilgajera-crest harshilgajera-crest commented May 13, 2024

  • Updated the md files for proper reference.
  • Added missing brackets

Fixes #834

@harshilgajera-crest harshilgajera-crest marked this pull request as ready for review May 13, 2024 12:35
@harshilgajera-crest harshilgajera-crest requested a review from a team as a code owner May 13, 2024 12:35
@kdoroszko-splunk
Copy link
Contributor

Lets change 'is not be mapped' to 'is not mapped' in these lines: cim_tests_line103, cim_tests_line109

@kdoroszko-splunk
Copy link
Contributor

Should we consider updating https://github.com/splunk/pytest-splunk-addon/pull/836/files#diff-49ba940f564070d4fac730e4d91f02a138324367030b4d4cd653cdb807f35345R53 with the latest template version (I mean remove volumes and adding platform for both services)?

@harshilgajera-crest
Copy link
Contributor Author

Should we consider updating https://github.com/splunk/pytest-splunk-addon/pull/836/files#diff-49ba940f564070d4fac730e4d91f02a138324367030b4d4cd653cdb807f35345R53 with the latest template version (I mean remove volumes and adding platform for both services)?

Done

@harshilgajera-crest
Copy link
Contributor Author

Lets change 'is not be mapped' to 'is not mapped' in these lines: cim_tests_line103, cim_tests_line109

Done

@kdoroszko-splunk kdoroszko-splunk self-requested a review May 14, 2024 07:38
@kdoroszko-splunk
Copy link
Contributor

generate-indextime-conf <path-to-addon [<path-to-the-new-conf-file]
- here are two missisng > sign

@kdoroszko-splunk kdoroszko-splunk self-requested a review May 14, 2024 08:49
@harshilgajera-crest harshilgajera-crest merged commit 82dd470 into main May 14, 2024
32 of 33 checks passed
@harshilgajera-crest harshilgajera-crest deleted the docs/fixing-documentation branch May 14, 2024 08:55
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.2.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation links and formatting
4 participants