-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): making a new release #874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated **url** rule so that if only url["path"] or url["query"] is given, just path and query is generated. EG: url["path"] will generate path like: "/random/path" EG: url["query"] will generate query like: "?asd=abs"
When tests are ran with multiple workers, duplicate logging is observed because every workers logs the warning. This PR fixes that. --------- Co-authored-by: Artem Rys <[email protected]>
Moved modules from standard_lib folder to its parent folder Kept addon_basic.py in standard_lib folder for backward compatibility.
This commit removes unused properties for tests which passed. This PR substitutes #873 PR. Co-authored-by: Harshil Gajera <[email protected]>
kdoroszko-splunk
previously approved these changes
Aug 7, 2024
mbruzda-splunk
previously approved these changes
Aug 7, 2024
This PR adds validation of HEC token. It just checks if an event can be send via given HEC token to external Splunk. Fix was tested locally. The result for 3 workers are presented in the attached screenshot (with pytest-splunk-addon code from develop branch it breaks main worker , restarts it and wait indefinitely). Although splunk_external fixture is defined in the session scope it runs on each worker separately. The following question arises: is it expected behaviour, or it's something we'd like to change (for the fixture logic to be executed before pytest splits for several processes). I do not believe that we have to check if Splunk is responsive from each worker separately. That would need to be explored (such solution might not be compatible with pytest): ![image](https://github.com/user-attachments/assets/95bd1c7c-d6ed-43d7-8249-7475e4760808)
f98a32c
artemrys
approved these changes
Aug 7, 2024
🎉 This issue has been resolved in version 5.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains below feature PRs: