Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): making a new release #874

Merged
merged 6 commits into from
Aug 7, 2024
Merged

chore(release): making a new release #874

merged 6 commits into from
Aug 7, 2024

Conversation

harshilgajera-crest and others added 4 commits August 2, 2024 11:46
Updated **url** rule so that if only url["path"] or url["query"] is
given, just path and query is generated.
EG: url["path"] will generate path like: "/random/path"
EG: url["query"] will generate query like: "?asd=abs"
When tests are ran with multiple workers, duplicate logging is observed
because every workers logs the warning.
This PR fixes that.

---------

Co-authored-by: Artem Rys <[email protected]>
Moved modules from standard_lib folder to its parent folder
Kept addon_basic.py in standard_lib folder for backward compatibility.
@harshilgajera-crest harshilgajera-crest changed the title Ci/feature release feat: enhancing PSA Aug 2, 2024
@harshilgajera-crest harshilgajera-crest marked this pull request as ready for review August 5, 2024 08:05
@harshilgajera-crest harshilgajera-crest requested review from a team as code owners August 5, 2024 08:05
This commit removes unused properties for tests which passed.

This PR substitutes #873 PR.

Co-authored-by: Harshil Gajera <[email protected]>
@artemrys artemrys changed the title feat: enhancing PSA chore(release): making a new release Aug 5, 2024
mbruzda-splunk
mbruzda-splunk previously approved these changes Aug 7, 2024
This PR adds validation of HEC token. It just checks if an event can be
send via given HEC token to external Splunk.
Fix was tested locally. The result for 3 workers are presented in the
attached screenshot (with pytest-splunk-addon code from develop branch
it breaks main worker , restarts it and wait indefinitely).
Although splunk_external fixture is defined in the session scope it runs
on each worker separately.
The following question arises: is it expected behaviour, or it's
something we'd like to change (for the fixture logic to be executed
before pytest splits for several processes). I do not believe that we
have to check if Splunk is responsive from each worker separately. That
would need to be explored (such solution might not be compatible with
pytest):

![image](https://github.com/user-attachments/assets/95bd1c7c-d6ed-43d7-8249-7475e4760808)
@artemrys artemrys merged commit ec91011 into main Aug 7, 2024
22 of 23 checks passed
@artemrys artemrys deleted the ci/feature-release branch August 7, 2024 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants