Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from Main into V2 #18

Merged
merged 11 commits into from
Apr 3, 2024

Conversation

greatestusername
Copy link
Contributor

@greatestusername greatestusername commented Mar 29, 2024

This is a cherry pick of #15
Specifically to get that commit from main which needs to be in v2 for release.
v2 is now set as the default branch for this repo also.


Before the change?

  • cherry pick commit accidentally merged to main instead of v2

After the change?

  • adds behavior for lastrunat and lastrunstatus

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output


Does this introduce a breaking change?

  • Yes
  • No

@greatestusername
Copy link
Contributor Author

@bchhay-splunk please check out this PR cherrypicking your commit for the lastRunAt and lastRunStatus properties.
Looks like just your changes but would love to have you give this PR a once over. 😄

@bchhay-splunk
Copy link
Collaborator

This LGTM! Thanks for doing this.

Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging commit into v2

@greatestusername-splunk greatestusername-splunk merged commit 749add8 into splunk:v2 Apr 3, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants