Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-3741: Add automaticRetries to the synthetics /test API #20

Merged
merged 3 commits into from
May 16, 2024

Conversation

kparvin
Copy link
Contributor

@kparvin kparvin commented Apr 3, 2024

This MR adds the automaticRetries attribute to all test types.

Resolves SYN-3741


Before the change?

  • automaticRetries field just defaulted to 0

After the change?

  • Users can set the automaticRetries field on any test to 1 or 0

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

PASS
coverage: 70.7% of statements
ok  	github.com/splunk/syntheticsclient/v2/syntheticsclientv2	1.795s	coverage: 70.7% of statements

Does this introduce a breaking change?

  • Yes
  • No

Copy link

github-actions bot commented Apr 3, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kparvin
Copy link
Contributor Author

kparvin commented Apr 3, 2024

I have read the CLA Document and I hereby sign the CLA

@kparvin
Copy link
Contributor Author

kparvin commented Apr 3, 2024

I have read the Code of Conduct and I hereby accept the Terms

srv-gh-tools added a commit to splunk/cla-agreement that referenced this pull request Apr 3, 2024
@kparvin kparvin marked this pull request as draft April 3, 2024 17:16
@kparvin kparvin changed the title Draft: SYN-3741: Add automaticRetries to the synthetics /test API SYN-3741: Add automaticRetries to the synthetics /test API May 14, 2024
@kparvin kparvin marked this pull request as ready for review May 14, 2024 16:04
@kparvin
Copy link
Contributor Author

kparvin commented May 14, 2024

@greatestusername-splunk Can you review this MR? For some reason github won't let me assign a reviewing in the UI.

Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greatestusername-splunk greatestusername-splunk merged commit bf6a9b5 into splunk:v2 May 16, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants