Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-3922: add support for downtime configurations #22

Merged
merged 3 commits into from
May 30, 2024

Conversation

bchhay-splunk
Copy link
Collaborator

Resolves #ISSUE_NUMBER


Before the change?

After the change?

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output


Does this introduce a breaking change?

  • Yes
  • No

@bchhay-splunk bchhay-splunk force-pushed the SYN-3922_v2 branch 2 times, most recently from eadfb31 to 0078b72 Compare May 21, 2024 19:38
@bchhay-splunk bchhay-splunk changed the title WIP: SYN-3922: add support for downtime configurations SYN-3922: add support for downtime configurations May 22, 2024
Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine approving this. Thank you so much for the contribution! 🚀 🎉

One comment/question regarding paging and if its worth having paging tested in the tests. But that can be a future piece of work.

syntheticsclientv2/get_downtimeconfigurationsv2_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that testing!

@greatestusername-splunk greatestusername-splunk merged commit dbfb5a2 into splunk:v2 May 30, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants