SYN-4088: Adds max_wait_time and wait_for_nav_timeout to browser steps #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new CLA workflow
update readme and contributing docs for CLA
…ties SYN-3197: Custom Properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://splunk.atlassian.net/browse/SYN-4088
Before the change?
Assert steps on browser steps did not allow you to configure a wait time (wait for x seconds for an element to appear). And steps with navigation did not allow you to configure how long to wait for a navigation event.
After the change?
Adds
max_wait_timeandwait_for_nav_timeoutto browser steps, allowing users to specify wait times. See https://splunk.enterprise.slack.com/docs/T024FQ3UW/F07BZ0A7TK6 for a small demo.Pull request checklist
make testacc), and pasted in this PR (for bug fixes / features)Acceptance Test Output
Does this introduce a breaking change?