Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYN-4088: Adds max_wait_time and wait_for_nav_timeout for browser tests #25

Merged
merged 2 commits into from
Jul 24, 2024
Merged

SYN-4088: Adds max_wait_time and wait_for_nav_timeout for browser tests #25

merged 2 commits into from
Jul 24, 2024

Conversation

sangn-splunk
Copy link
Collaborator

@sangn-splunk sangn-splunk commented Jul 22, 2024 •
edited
Loading

Resolves https://splunk.atlassian.net/browse/SYN-4088

Before the change?

  • Assert steps on browser steps did not allow you to configure a wait time (wait for x seconds for an element to appear). And steps with navigation did not allow you to configure how long to wait for a navigation event.

After the change?

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

https://github.com/splunk/syntheticsclient/actions/runs/10048580222/job/27772849666?pr=25

Does this introduce a breaking change?

  • Yes
  • No

greatestusername-splunk
greatestusername-splunk approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a small linting thing.

syntheticsclientv2/common_models.go Outdated Show resolved Hide resolved
@sangn-splunk sangn-splunk merged commit 678ba62 into splunk:v2 Jul 24, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greatestusername-splunk greatestusername-splunk greatestusername-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sangn-splunk @greatestusername-splunk