Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-4606: Add WaitForNavTimeoutDefault and MaxWaitTimeDefault #30

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Pajk
Copy link
Collaborator

@Pajk Pajk commented Nov 13, 2024

Resolves SYN-4606


Before the change?

  • No way how to find out if the WaitForNavTimeout and MaxWaitTime browser check step fields were set to some value or the default value is being used. This information is needed in the Synthetics Terraform provider to properly handle default values.

After the change?

  • Added WaitForNavTimeoutDefault and MaxWaitTimeDefault boolean flags. When true, the value in the respective attributes is the default one provided by the API. If false, the value was set to the value by the user in UI or through the Synthetics API.

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

PASS
coverage: 70.3% of statements
ok      github.com/splunk/syntheticsclient/v2/syntheticsclientv2        1.343s  coverage: 70.3% of statements

Does this introduce a breaking change?

  • Yes
  • No

@Pajk Pajk merged commit c503e10 into splunk:v2 Nov 15, 2024
3 checks passed
@Pajk Pajk deleted the SYN-4606-default-values branch November 15, 2024 10:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants