Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-3798: add last_run_status and last_run_at to /tests/ response #42

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

bchhay-splunk
Copy link
Collaborator

@bchhay-splunk bchhay-splunk commented Mar 15, 2024

Resolves #ISSUE_NUMBER


Before the change?

After the change?

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output


Does this introduce a breaking change?

  • Yes
  • No

@greatestusername-splunk
Copy link
Collaborator

Reviewing changes in synthetics client

@greatestusername-splunk
Copy link
Collaborator

https://github.com/splunk/syntheticsclient/releases/tag/v2.0.6
Should be released and usable for this stuff. Thank you for contributing!

@bchhay-splunk
Copy link
Collaborator Author

@greatestusername-splunk i pulled in the vendor changes for the newest tag. should be good to go now!

@greatestusername-splunk
Copy link
Collaborator

Passes acceptance test

terraform-provider-synthetics 12:11> make testacc
TF_ACC=1 go test $(go list ./... | grep -v 'vendor')  -timeout 120m   | sed '/X-Sf-Token/d'
?       github.com/splunk/terraform-provider-synthetics [no test files]
ok      github.com/splunk/terraform-provider-synthetics/synthetics      38.343s

Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only updates datasources and adds to structures

@greatestusername-splunk greatestusername-splunk merged commit 3d51d05 into splunk:main Apr 23, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants