This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
exec healthchecks: remove check of executionDriver #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spotify/helios-team @mbruggmann |
mattnworb
force-pushed
the
exec-healthcheck-requirements
branch
from
24e8b7b to
903594e
Compare
|
This is related to #916 but also I was surprised to see that an exec healthcheck didn't work when deploying things to a local helios-solo with docker-machine / vmware. |
mattnworb
force-pushed
the
exec-healthcheck-requirements
branch
from
903594e to
e3675cb
Compare
There are some environments, such as docker-machine on Mac or Docker for Mac, where `docker exec` works just fine but they seem to return an empty string for `ExecutionDriver` from the `/info` endpoint in the Docker Remote API. This change removes the check that only executes the exec healthcheck when `executionDriver` starts with `native`, so that exec healthchecks can still be used (and jobs with them can be deployed) in these environments.
mattnworb
force-pushed
the
exec-healthcheck-requirements
branch
from
e3675cb to
1777adf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some environments, such as docker-machine on Mac or Docker for
Mac, where
docker execworks just fine but they seem to return anempty string for
ExecutionDriverfrom the/infoendpoint in theDocker Remote API.
This change removes the check that only executes the exec healthcheck
when
executionDriverstarts withnative, so that exec healthcheckscan still be used (and jobs with them can be deployed) in these
environments.