-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ improvements #63
C++ improvements #63
Conversation
6ead919
to
406b4e0
Compare
@@ -0,0 +1 @@ | |||
cpp/.clang-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
softlink to allow the clang-format github action to work correctly
51bf712
to
be468a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, but if we're adding C++ tests (even just the one) in this PR, IMO we should add them to the GitHub Actions workflow so they run on CI before merging this.
CONTRIBUTING.md
Outdated
mvn package | ||
``` | ||
|
||
this will update the java documentation located in [docs/java/](https://github.com/spotify/voyager/tree/main/docs/java). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will update the java documentation located in [docs/java/](https://github.com/spotify/voyager/tree/main/docs/java). | |
This will update the java documentation located in [docs/java/](https://github.com/spotify/voyager/tree/main/docs/java). |
without any pressure - is there a timeframe for merging this? just asking for our own planning on when to start integrating these changes |
just a friendly ping - any update on this? do you think it makes sense for potential users to start picking up your branch directly instead of waiting for this to be merged? @markkohdev |
.github/workflows/all.yml
Outdated
@@ -37,10 +37,9 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v3 | |||
- name: Check C++ Formatting | |||
uses: jidicula/clang-format-action@v4.4.1 | |||
uses: jidicula/clang-format-action@v4.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add c++ action container
1712632
to
ec40dc9
Compare
a875599
to
bba8a5a
Compare
97e216f
to
6cc7614
Compare
0ce71d7
to
9c6af20
Compare
9c6af20
to
1f6c0b1
Compare
Description
In this PR we will:
Changes Made
C++
Main changes:
cpp
dir intosrc
andtest
directoriesPython
voyager-headers
link since it doesn't seem to be neededJava
Testing
Checklist
Additional Comments