Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken example #1068

Merged
merged 1 commit into from
May 9, 2024
Merged

Fix broken example #1068

merged 1 commit into from
May 9, 2024

Conversation

Jack-Dane
Copy link
Contributor

No description provided.

@Jack-Dane
Copy link
Contributor Author

Fixes an issue with the example raised in #1066.

@dieser-niko
Copy link
Member

I would go a different way. The reason this fails at all is because the next url is /playlists/<playlist_id>/tracks while the initial request url is /playlists/<playlist_id>. It should be more straight forward with sp.playlist_tracks instead of sp.playlist so we can get a consistent response.

@Jack-Dane
Copy link
Contributor Author

@dieser-niko, thanks for the review, I found the same when investigating the bug, but I didn't know the method you mentioned was available.

I agree with your proposed changes, the slight change being that playlist_tracks is deprecated with the suggestion to use playlist_items. Still, it calls the same endpoint mentioned.

@dieser-niko
Copy link
Member

I guess I missed the deprecation warning, there were just too many prints :P

One thing tho, even though the warning says to use additional_types=('track',)), it didn't say to remove the fields parameter. I think it would be better to add it since it was a part of the example before. In this case it should be fields="items,next".

* It will request the same endpoint as sp.next with the same fields for consistency.
@Jack-Dane
Copy link
Contributor Author

@dieser-niko, yep, my bad, updated to still include the fields kwarg.

@dieser-niko dieser-niko merged commit 23bf3c9 into spotipy-dev:master May 9, 2024
6 checks passed
@Msoyosa
Copy link

Msoyosa commented Jun 7, 2024

Hi Jack, thank you for your plugin for CF7 integration with Odoo. Can I ask how to include the company name and marketing tag, the marketing tag has a Odoo field name "x_studio_marketing_tag" - many to many. They are not reflecting in Odoo, both the company name and marketing tag. Thank you.

@dieser-niko
Copy link
Member

@Msoyosa please visit Jack Danes repository and open an issue there. The topic of your comment does not seem to be related to the Spotipy library and should not be discussed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants