requests: Block use of http.DefaultClient

spotlightpa · Aug 9, 2024 · 5957031 · 5957031
1 parent 6eb4476
commit 5957031
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/pkg/almanack/flags.go b/pkg/almanack/flags.go
@@ -14,6 +14,7 @@ import (
 	"github.com/spotlightpa/almanack/internal/index"
 	"github.com/spotlightpa/almanack/internal/mailchimp"
 	"github.com/spotlightpa/almanack/internal/plausible"
+	"github.com/spotlightpa/almanack/pkg/almlog"
 )
 
 func AddFlags(fl *flag.FlagSet) func() (svc Services, err error) {
@@ -42,7 +43,9 @@ func AddFlags(fl *flag.FlagSet) func() (svc Services, err error) {
 			return
 		}
 
-		client := *http.DefaultClient
+		client := http.Client{
+			Transport: almlog.HTTPTransport,
+		}
 
 		is, fs := getS3Store()
 		mc := mailchimp.NewMailService(*mailServiceAPIKey, *mailServiceListID, &client)

diff --git a/pkg/almlog/httplogger.go b/pkg/almlog/httplogger.go
@@ -1,14 +1,19 @@
 package almlog
 
 import (
+	"errors"
 	"net/http"
 	"time"
 
 	"github.com/carlmjohnson/requests"
 )
 
+var HTTPTransport http.RoundTripper
+
 func init() {
-	http.DefaultTransport = requests.LogTransport(http.DefaultTransport, logReq)
+	HTTPTransport = requests.LogTransport(http.DefaultTransport, logReq)
+	http.DefaultTransport = requests.ErrorTransport(errors.New("use of http.DefaultTransport"))
+	http.DefaultClient.Transport = requests.ErrorTransport(errors.New("use of http.DefaultClient"))
 }
 
 func logReq(req *http.Request, res *http.Response, err error, duration time.Duration) {