This repository has been archived by the owner on Apr 17, 2020. It is now read-only.
Ensure that the other address is always new #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user clicks the radio button to enter another address, this form was prefilled by spree default address for this user. This is NOT what we want. We want the address to always to be fresh. Otherwise in cinjuntion with the `Spree::UserAdress` module the preferred bill and shipping will be updated by the new address. We always want to create a new temporary address.
The previous commit introduced, that the "Other address" radio button showed an empty form. But we want to see the filled form when we get a validation error. This fixes it.
|
Can anyone merge this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user clicks the radio button to enter another address, this form was prefilled by spree default address for this user. This is NOT what we want. We want the address to always to be fresh.
Otherwise in conjuntion with the
Spree::UserAdressmodule the preferred bill and shipping will be updated by the new address.We almost always want to create a new temporary address, only when a validation error occurs we want to render the entered address.