Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate by 250 instead of by 50 #2

Open
vfonic opened this issue Mar 8, 2018 · 0 comments
Open

Paginate by 250 instead of by 50 #2

vfonic opened this issue Mar 8, 2018 · 0 comments

Comments

@vfonic
Copy link
Contributor

vfonic commented Mar 8, 2018

You could add limit: 250 to the default opts here: https://github.com/spree-contrib/spree_shopify_importer/blob/master/app/services/spree_shopify_importer/connections/base.rb#L21

It will speed up large stores import by almost 5 times by returning 250 items instead of 50 per page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant