Support ssl configuration from files #52
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the configuration for endpoints and SSL to support other Erlang SSL options, most importantly getting certs and keys from files.
It's compatible with the current code, except that instead of having the
heroku_kafka_env: true
option, it has an optional
ssl
option, and theKAFKA_CLIENT_CERT
andKAFKA_CLIENT_CERT_KEY
environment vars are added to thessl
config if present. It also fully supports theKAFKA_TRUSTED_CERT
environment var.If the
KAFKA_URL
environment var is set, it reads the endpoints from there, overriding anything set in theendpoints
config option.This PR includes a full set of unit tests. I haven't tested it with Heroku Kafka, as we are running our own Kafka servers.