Sleuth now uses Brave #829
Merged
+8,168
−18,118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's done? - Web Server - Simple handler interceptor - Web Clients - RestTemplate - Slf4j - with Brave in place it will also work for any other implementation (e.g. log4j) In progress TraceCallable and TraceRunnable in order to then do stuff with asyncs and then eventually callable on mvc to make the next samples pass.
there's still the issue546 package to copy but it requires instrumentation of async rest template etc. For now, the goal is to make the async servlet support work
can't make org.springframework.cloud.brave.instrument.web.TraceWebAsyncClientAutoConfigurationTests pass due to missing client side spans. That's because the `finish()` method in brave returns a null span and the `reporter` is not called.
added some tests, added default http client parser
spencergibb
reviewed
Jan 19, 2018
| if (log.isDebugEnabled()) { | ||
| log.debug("Adding an error tag [" + errorMsg + "] to span " + span); | ||
| } | ||
| span.tag(Span.SPAN_ERROR_TAG_NAME, errorMsg); | ||
| span.tag("error", errorMsg); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this pull request we have rewritten the whole Sleuth internals to use Brave. That way we can leverage all the functionalities & instrumentations that Brave already has (https://github.com/openzipkin/brave/tree/master/instrumentation).
Migration guide is available here: https://github.com/spring-cloud/spring-cloud-sleuth/wiki/Spring-Cloud-Sleuth-2.0-Migration-Guide
fixes #711 - Brave instrumentation
fixes #92 - we move to Brave's Sampler
fixes #143 - Brave is capable of passing context
fixes #255 - we've moved away from Zipkin Stream server
fixes #305 - Brave has GRPC instrumentation (https://github.com/openzipkin/brave/tree/master/instrumentation/grpc)
fixes #459 - Brave (openzipkin/brave#510) & Zipkin (openzipkin/zipkin#1754) will deal with the AWS XRay instrumentation
fixes #577 - Messaging instrumentation has been rewritten