Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser should apply to OpenRewrite styles #982

Open
3 tasks
Tracked by #844
fabapp2 opened this issue Oct 31, 2023 · 2 comments
Open
3 tasks
Tracked by #844

Parser should apply to OpenRewrite styles #982

fabapp2 opened this issue Oct 31, 2023 · 2 comments
Assignees
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: enhancement New feature or request

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Oct 31, 2023

What needs to be done

It should be possible to provide OpenRewrite Style settings to the parser.

  • A default set of styles should be provided if reasonable (what is the default with OR?)
  • The set of styles should be provided as application properties
parser.styles=com.foo.MyStyle,com.bar.YourStyle
  • The default is set in ParserProperties

  • The style should be provided where required (ExecutionContext, Parser(s), ..)

  • Implemented code and tests that verify

    • Styles from properties are used
    • Code is formatted using the configured style(s)

OpenRewrite docs

@shresthaujjwal
Copy link

shresthaujjwal commented Nov 9, 2023

I can look into this. Can you assign this to me

@fabapp2 fabapp2 added type: enhancement New feature or request in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp labels Nov 12, 2023
@fabapp2
Copy link
Contributor Author

fabapp2 commented Nov 14, 2023

HI @shresthaujjwal
Yes, you can.
I haven't looked into this myself yet besides scanning the docs.
I will enhance the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants