Application custom conversions override spring-data-couchbase custom conversions since v5

[roman-sinyakov]

We use Couchbase configuration with our own custom conversions declared like below since v4:

public class CouchbaseConfig extends AbstractCouchbaseConfiguration {
    ...

    @Override
    @Bean(name = BeanNames.COUCHBASE_CUSTOM_CONVERSIONS)
    public CustomConversions customConversions () {
        return new CouchbaseCustomConversions(<our own convertors>);
    }

Method AbstractCouchbaseConfiguration.customConversions() is empty in v4:

public abstract class AbstractCouchbaseConfiguration {
        ...
	@Bean(name = BeanNames.COUCHBASE_CUSTOM_CONVERSIONS)
	public CustomConversions customConversions() {
		return new CouchbaseCustomConversions(Collections.emptyList());
	}

After upgrade to v5 spring-data-couchbase owned convertors (e.g. StringToEnumConverterFactory) stopped working since this method AbstractCouchbaseConfiguration.customConversions() started declaring them since v5:

public abstract class AbstractCouchbaseConfiguration {
        ...
        public CustomConversions customConversions() {
		return customConversions(getCryptoManager(), getObjectMapper());
	}

I cannot see any way to have our own custom convertors and keep spring-data-couchbase custom convertors at the same time.
spring-data-couchbase 5.1.4
Please help

[mikereiche]

Thanks for the description. I'll look into this.

[mikereiche]

This isn't great, but you can copy/override AbstractCouchbaseConfiguration.customConversions(getCryptoManager(), getObjectMapper()) and add your converters to newConverters.

	public CustomConversions customConversions(CryptoManager cryptoManager, ObjectMapper objectMapper) {
		List<Object> newConverters = new ArrayList();
		// newConverters.add(....) // <-- add here
		newConverters.add(new OtherConverters.EnumToObject(getObjectMapper()));
		newConverters.add(new IntegerToEnumConverterFactory(getObjectMapper()));
		newConverters.add(new StringToEnumConverterFactory(getObjectMapper()));
		newConverters.add(new BooleanToEnumConverterFactory(getObjectMapper()));
		CustomConversions customConversions = CouchbaseCustomConversions.create(configurationAdapter -> {
			SimplePropertyValueConversions valueConversions = new SimplePropertyValueConversions();
			valueConversions.setConverterFactory(
					new CouchbasePropertyValueConverterFactory(cryptoManager, annotationToConverterMap(), objectMapper));
			valueConversions.setValueConverterRegistry(new PropertyValueConverterRegistrar().buildRegistry());
			valueConversions.afterPropertiesSet(); // wraps the CouchbasePropertyValueConverterFactory with CachingPVCFactory
			configurationAdapter.setPropertyValueConversions(valueConversions);
			configurationAdapter.registerConverters(newConverters);
		});
		return customConversions;
	}

Eventually I can replace the customConversions(CryptoManager, ObjectMapper) method with

public CustomConversions customConversions(CryptoManager cryptoManager, ObjectMapper objectMapper, List<Object> newConverters ) {

[bipoool]

hey @mikereiche, Can I work on this? If you have not started working on this?

[bipoool]

hey @mikereiche @roman-sinyakov, I've Raised a PR for this. Can you please check this?
#1886

[mikereiche]

Thanks very much. I'll look at it next week.

[bipoool]

Any Update here? @mikereiche