Added functionality to add customConverters. #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mikereiche
reviewed
Jan 10, 2024
| newConverters.add(new IntegerToEnumConverterFactory(getObjectMapper())); | ||
| newConverters.add(new StringToEnumConverterFactory(getObjectMapper())); | ||
| newConverters.add(new BooleanToEnumConverterFactory(getObjectMapper())); | ||
| List<Object> newConverters = additionalConverters(); |
There was a problem hiding this comment.
Thank you for submitting the pull request.
Just leave the newConverters as-is, then instead of calling the new additionalConverters() here, call
registerAdditionalConverters(newConverters)
But rename registerAdditionalConverters to additionalConverters().
There was a problem hiding this comment.
Changes are Done @mikereiche
mikereiche
added
type: task
Added functionality to register custom converters in the list + cleaned up the code a little and.
Function name changed and restored to old implementation
bipoool
force-pushed
the
feature/registerCustomConverter
branch
from
30bfcf4 to
2c876e5
Compare
mikereiche
pushed a commit
that referenced
this pull request
Jan 18, 2024
* Added functionality to add customConverters. Added functionality to register custom converters in the list + cleaned up the code a little and. * Review chages. Function name changed and restored to old implementation * Documentation Changes.
mikereiche
pushed a commit
that referenced
this pull request
Jan 18, 2024
* Added functionality to add customConverters. Added functionality to register custom converters in the list + cleaned up the code a little and. * Review chages. Function name changed and restored to old implementation * Documentation Changes.
mikereiche
pushed a commit
that referenced
this pull request
Jan 18, 2024
* Added functionality to add customConverters. Added functionality to register custom converters in the list + cleaned up the code a little and. * Review chages. Function name changed and restored to old implementation * Documentation Changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to register custom converters in the list + cleaned up the code a little. Let me know if I have to add test cases for this. Not added yet as the change was small. Fixes #1876.