Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spring Data Querydsl example. #681

Conversation

timothysparg
Copy link

@timothysparg timothysparg commented Jul 26, 2024

The io.github.jpenren:thymeleaf-spring-data-dialect dependency was out of sync with thymeleaf causing an error when you tried to access the index page.

Additionally Added a TestApplication and revamped the TestContainers usage.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

The io.github.jpenren:thymeleaf-spring-data-dialect dependency was out of sync with thymeleaf causing an error when you tried to access the index page.

Additionally Added a TestApplication and revamped the TestContainers usage.
@timothysparg timothysparg force-pushed the update-web-querydsl-examples branch from 07b97fe to df2c6ab Compare July 26, 2024 15:20
@odrotbohm
Copy link
Member

That's merged. Thanks, Tim.

@odrotbohm odrotbohm closed this Jul 29, 2024
@odrotbohm odrotbohm removed the status: waiting-for-triage An issue we've not yet triaged label Jul 29, 2024
@timothysparg timothysparg deleted the update-web-querydsl-examples branch July 30, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants