Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 potential flaky tests in
MapKeyValueAdapterUnitTests.java
file.In the test
scanShouldIterateOverAvailableEntries()
, we rely on the fact that the map has a specific order. However, as the key space map for COLLECTION_1 is initialized as aConcurrentHashMap
, it is not guaranteed that the order will remain constant over time according to the Java documentation.Such indeterministic characteristic of ConcurrentHashMap will cause this test to fail in some platforms or specific machines that adopt a different iteration order.
To fix it, I will first iterate through all the entries in the map, and based on the key of the first entry, we then compare two entries accordingly.
The same fix also applies to
scanDoesNotMixResultsFromMultipleKeyspaces()
.