Adds support for parameterized @Query including ValueExpressions #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Oct 21, 2024
src/main/java/org/springframework/data/ldap/repository/query/LdapParameters.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/ldap/repository/query/AnnotatedLdapRepositoryQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/ldap/repository/query/BindingContext.java
Outdated
Show resolved
Hide resolved
.../org/springframework/data/ldap/repository/query/ValueExpressionLdapRepositoryQueryTests.java
Outdated
Show resolved
Hide resolved
Refactor ContextualValueExpressionEvaluator into Function, refactor BindingContext into nested class. Simplify tests. Rename tests to reflect what they are actually doing. Reformat code.
| @@ -141,27 +108,18 @@ EmbeddedLdapProperties embeddedLdapProperties() { | |||
| interface QueryRepository extends LdapRepository<SchemaEntry> { | |||
|
|
|||
| @Query(value = "(cn=:fullName)") | |||
| List<SchemaEntry> namedParameters(@Param("fullName") String fullName, @Param("lastName") String lastName); | |||
| List<SchemaEntry> namedParameters(String fullName); | |||
There was a problem hiding this comment.
Just FYI I've deliberately added two parameters so that we're sure that the proper one is picked.
There was a problem hiding this comment.
Indeed makes sense to have this test, see AnnotatedLdapRepositoryQueryUnitTests.shouldEncodeBase.
We like to keep integration test rather reduced to the minimum that is necessary. We tend to explore invariants in unit tests.
Tweak wording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #453