Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reactive SimpleReactiveMongoRepository.saveAll flow #4843

Closed
wants to merge 8 commits into from
Closed

Update reactive SimpleReactiveMongoRepository.saveAll flow #4843

wants to merge 8 commits into from

Conversation

christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Nov 25, 2024 •
edited
Loading

This PR updates the reactive save all execution path for save operations using Iterable & Publisher in a way that makes sure the first element is completely processed before continuing with other server calls. In doing so we make sure a potential flag indicating transaction start is sent before continuing with the remaining server calls.

@christophstrobl christophstrobl linked an issue Nov 26, 2024 that may be closed by this pull request
Improve reactive Repository save operation flow #4838
Closed
@christophstrobl christophstrobl marked this pull request as ready for review November 28, 2024 11:16
@mp911de mp911de changed the title Update reactive saveAll flow. Update reactive SimpleReactiveMongoRepository.saveAll flow Nov 28, 2024
@mp911de mp911de added this to the 4.5 M1 (2025.0.0) milestone Nov 28, 2024
@mp911de mp911de added the type: enhancement A general enhancement label Nov 28, 2024
mp911de pushed a commit that referenced this pull request Nov 28, 2024
@christophstrobl @mp911de
Update reactive SimpleReactiveMongoRepository.saveAll flow.
94a4fe7 
Closes #4838
Original pull request: #4843
mp911de pushed a commit that referenced this pull request Nov 28, 2024
@christophstrobl @mp911de
Fix flakey test by asserting execution order.
721799d 
See #4838
Original pull request: #4843
mp911de added a commit that referenced this pull request Nov 28, 2024
@mp911de
Polishing.
5b86b2f 
Switch to Flux.fromIterable(…) from StreamUtils in deleteAll(Iterable). Use switch expressions, refine toList/toCollection arrangement. Guard tests against absent ReplicaSet.

See #4838
Original pull request: #4843
@mp911de mp911de closed this Nov 28, 2024
@mp911de mp911de deleted the issue/4838 branch November 28, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.5 M1 (2025.0.0)
Development

Successfully merging this pull request may close these issues.

Improve reactive Repository save operation flow
2 participants
@christophstrobl @mp911de