refactor: Extract requiresSingleStatements for better readability.

Co-authored-by: Michael Simons <[email protected]>
spring-projects · Nov 27, 2023 · 4eb08ab · 4eb08ab
1 parent 52f6714
commit 4eb08ab
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/main/java/org/springframework/data/neo4j/core/Neo4jTemplate.java b/src/main/java/org/springframework/data/neo4j/core/Neo4jTemplate.java
@@ -467,6 +467,13 @@ public <T> List<T> saveAll(Iterable<T> instances) {
 		return saveAllImpl(instances, Collections.emptySet(), null);
 	}
 
+	private boolean requiresSingleStatements(boolean heterogeneousCollection, Neo4jPersistentEntity<?> entityMetaData) {
+		return heterogeneousCollection
+				|| entityMetaData.isUsingInternalIds()
+				|| entityMetaData.hasVersionProperty()
+				|| entityMetaData.getDynamicLabelsProperty().isPresent();
+	}
+
 	private <T> List<T> saveAllImpl(Iterable<T> instances, @Nullable Collection<PropertyFilter.ProjectedPath> includedProperties, @Nullable BiPredicate<PropertyPath, Neo4jPersistentProperty> includeProperty) {
 
 		Set<Class<?>> types = new HashSet<>();
@@ -489,8 +496,8 @@ private <T> List<T> saveAllImpl(Iterable<T> instances, @Nullable Collection<Prop
 						includeProperty);
 
 		Neo4jPersistentEntity<?> entityMetaData = neo4jMappingContext.getRequiredPersistentEntity(domainClass);
-		if (heterogeneousCollection || entityMetaData.isUsingInternalIds() || entityMetaData.hasVersionProperty()
-				|| entityMetaData.getDynamicLabelsProperty().isPresent()) {
+
+		if (requiresSingleStatements(heterogeneousCollection, entityMetaData)) {
 			log.debug("Saving entities using single statements.");
 
 			NestedRelationshipProcessingStateMachine stateMachine = new NestedRelationshipProcessingStateMachine(neo4jMappingContext);