Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use use module name to obtain module prefix in RedisRepositoryConfigurationExtension #2762

Conversation

junghoon-vans
Copy link
Contributor

@junghoon-vans junghoon-vans commented Nov 6, 2023

In my opinion, returning the module name directly is not a good idea,
so I modified it to handle it by declaring a constant instead.
Also, instead of returning a value directly from getModulePrefix, we can proxies it to this.getModuleIdentifier.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 6, 2023
mp911de pushed a commit that referenced this pull request Nov 6, 2023
Use module identifier instead of constant.

Closes #2762
mp911de added a commit that referenced this pull request Nov 6, 2023
Use module name defaulting to determine module prefix.

Closes #2762
@mp911de mp911de closed this in 22a465a Nov 6, 2023
@mp911de mp911de changed the title Make constant for repository module name Use use module name to obtain module prefix in RedisRepositoryConfigurationExtension Nov 6, 2023
@mp911de
Copy link
Member

mp911de commented Nov 6, 2023

With a smarter defaulting in KeyValueRepositoryConfigurationExtension (spring-projects/spring-data-keyvalue#542) we were able to actually remove a bit of code. Thank you for your contribution, that's polished, merged, and backported now.

@mp911de mp911de added this to the 3.1.6 (2023.0.6) milestone Nov 6, 2023
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants