Correctly handle errors when saving to yaml

springload · Nov 16, 2021 · f2768cb · f2768cb
1 parent 1dcb606
commit f2768cb
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/lib/cache/yaml.go b/lib/cache/yaml.go
@@ -10,6 +10,7 @@ import (
 
 	"gopkg.in/yaml.v2"
 
+	"github.com/hashicorp/go-multierror"
 	fuzzyfinder "github.com/ktr0731/go-fuzzyfinder"
 )
 
@@ -81,10 +82,11 @@ func (y *YAMLCache) Save(profileSummaries []lib.ProcessedProfileSummary) error {
 	if err != nil {
 		return err
 	}
+	var errors error
 	// every ssh entry is self-contained
 	for _, summary := range profileSummaries {
 		for _, sshEntry := range summary.SSHEntries {
-			func() error {
+			if err := func() error {
 				var fileName = path.Join(instancesPath, fmt.Sprintf("%s.yaml", sshEntry.InstanceID))
 				file, err := os.OpenFile(fileName, os.O_WRONLY|os.O_CREATE, 0644)
 				if err != nil {
@@ -114,9 +116,14 @@ func (y *YAMLCache) Save(profileSummaries []lib.ProcessedProfileSummary) error {
 					}
 				}
 				return nil
-			}()
+			}(); err != nil {
+				errors = multierror.Append(errors, err)
+			}
 		}
 	}
+	if errors != nil {
+		return errors
+	}
 	sort.Strings(y.index.CanonicalNames)
 	y.index.InstancesIndex = index