Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove comma from depositNonce string number #217

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: remove comma from depositNonce string number #217

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5786dd
remove comma from depositNonce string number;
tcar121293 Sep 11, 2024
5165184
optimize code;
tcar121293 Sep 11, 2024
f31915d
lint code;
tcar121293 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/indexer/utils/substrate/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ export async function saveProposalExecution(
transferRepository: TransferRepository,
): Promise<void> {
const { originDomainId, depositNonce, txIdentifier, blockNumber, timestamp } = proposalExecutionData

let transfer = await transferRepository.findTransfer(Number(depositNonce), Number(originDomainId), toDomainId)
const numDepositNonce = Number(depositNonce.replace(/,/g, ""))
let transfer = await transferRepository.findTransfer(numDepositNonce, Number(originDomainId), toDomainId)
if (!transfer) {
transfer = await transferRepository.insertExecutionTransfer(
{
depositNonce: Number(depositNonce),
depositNonce: numDepositNonce,
fromDomainId: originDomainId,
},
toDomainId,
Expand All @@ -71,13 +71,14 @@ export async function saveFailedHandlerExecution(
transferRepository: TransferRepository,
): Promise<void> {
const { originDomainId, depositNonce, txIdentifier, blockNumber, error, timestamp } = failedHandlerExecutionData
const numDepositNonce = Number(depositNonce.replace(/,/g, ""))

let transfer = await transferRepository.findTransfer(Number(depositNonce), Number(originDomainId), toDomainId)
let transfer = await transferRepository.findTransfer(numDepositNonce, Number(originDomainId), toDomainId)
// there is no transfer yet, but a proposal execution exists
if (!transfer) {
transfer = await transferRepository.insertFailedTransfer(
{
depositNonce: Number(depositNonce),
depositNonce: numDepositNonce,
domainId: originDomainId,
message: Buffer.from(error).toString(),
},
Expand Down Expand Up @@ -120,12 +121,11 @@ export async function saveDeposit(
} = substrateDepositData

const currentDomain = sharedConfig.domains.find(domain => domain.id === originDomainId)

const tokenSymbol = currentDomain?.resources.find(resource => resource.resourceId === resourceId)?.symbol

const decodedAmount = getDecodedAmount(depositData)
const numDepositNonce = Number(depositNonce.replace(/,/g, ""))

let transfer = await transferRepository.findTransfer(Number(depositNonce), originDomainId, Number(destinationDomainId))
let transfer = await transferRepository.findTransfer(numDepositNonce, originDomainId, Number(destinationDomainId))

let amountInUSD

Expand All @@ -138,7 +138,7 @@ export async function saveDeposit(

if (transfer) {
let dataTransferToUpdate = {
depositNonce: Number(depositNonce),
depositNonce: numDepositNonce,
amount: decodedAmount,
resourceID: resourceId,
fromDomainId: originDomainId.toString(),
Expand Down Expand Up @@ -168,7 +168,7 @@ export async function saveDeposit(
} else {
const transferData = {
id: new ObjectId().toString(),
depositNonce: Number(depositNonce),
depositNonce: numDepositNonce,
sender,
amount: decodedAmount,
resourceID: resourceId,
Expand Down
Loading